feat: add admin consent endpoint for DIAL_NATIVE services - #1820
Merged
Conversation
DmytroZaichenkoDev
requested review from
Oleksii-Klimov and
astsiapanay
as code owners
August 11, 2026 10:43
DmytroZaichenkoDev
force-pushed
the
feat/dial-native-admin-consent
branch
from
August 11, 2026 10:50
7b27033 to
39e2f55
Compare
astsiapanay
reviewed
Aug 11, 2026
DmytroZaichenkoDev
force-pushed
the
feat/dial-native-admin-consent
branch
from
August 11, 2026 13:38
39e2f55 to
38d62c8
Compare
DmytroZaichenkoDev
force-pushed
the
feat/dial-native-admin-consent
branch
from
August 11, 2026 14:44
38d62c8 to
9fe0a14
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
astsiapanay
previously approved these changes
Aug 12, 2026
DmytroZaichenkoDev
force-pushed
the
feat/dial-native-admin-consent
branch
from
August 12, 2026 12:18
e7128d0 to
caca038
Compare
This comment has been minimized.
This comment has been minimized.
DmytroZaichenkoDev
force-pushed
the
feat/dial-native-admin-consent
branch
from
August 12, 2026 13:00
caca038 to
0a1a2ad
Compare
This comment has been minimized.
This comment has been minimized.
astsiapanay
approved these changes
Aug 12, 2026
Base automatically changed from
feat/offline-credentials-endpoints
to
development
August 12, 2026 13:16
An administrator approves an application's use of a DIAL-native service via
POST/DELETE /v1/applications/{appId}/external-services/{id}/consent. The
approval is a credential record in the APPLICATION-level slot — its existence
is the consent, the audit event records who decided. Because that slot holds
ordinary credentials while a service is OAUTH/API_KEY, any write that changes
a service's authentication_type now purges the old APPLICATION-level record,
so a leftover credential can never pass as an approval, and client secrets
are never carried across a type change. Consent operations are admin-only
and audited, including refusals.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Both credential writes ended in the same encrypt + put sequence; extracted storeEncrypted so putCredentialsRecord and addResourceCredentials share it. Also pins with a test that the consent route and the management route can never cross-match: the service id disallows '/', both patterns are anchored, and even an app path containing an external-services segment or a service named 'consent' stays on its own route. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
DmytroZaichenkoDev
force-pushed
the
feat/dial-native-admin-consent
branch
from
August 12, 2026 13:16
0a1a2ad to
bd0244c
Compare
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 3/4 of the offline-delegation split (replaces #1815). Based on #1819.
An administrator approves an application's use of a DIAL-native service via
POST/DELETE/v1/applications/{appId}/external-services/{id}/consent. The approval is a record in the APPLICATION-level credentials slot; the audit event records who decided. Any write that changes a service'sauthentication_typenow purges the old APPLICATION-level record, so a leftover credential can never pass as an approval. Admin-only, audited including refusals.🤖 Generated with Claude Code